Browse code

Merge branch 'trunk' into devel

mikejiang authored on 12/04/2018 17:54:10
Showing 5 changed files

... ...
@@ -1,7 +1,7 @@
1 1
 Package: flowWorkspace
2 2
 Type: Package
3 3
 Title: Infrastructure for representing and interacting with the gated cytometry
4
-Version: 3.27.24
4
+Version: 3.27.25
5 5
 Date: 2011-06-10
6 6
 Author: Greg Finak, Mike Jiang
7 7
 Maintainer: Greg Finak <gfinak@fhcrc.org>,Mike Jiang <wjiang2@fhcrc.org>
... ...
@@ -209,11 +209,12 @@ test_that("keyword",{
209 209
       #skip flowCore_R keys due to the historical archived results do not have this info up to date
210 210
       thisRes <- thisRes[!grepl("(flowCore_\\$P)|(transformation)",names(thisRes))]
211 211
       expectRes <- expectRes[!grepl("(flowCore_\\$P)|(transformation)",names(expectRes))]
212
+      #fix legacy result
213
+      expectRes[paste0("$P",5:11, "N")] <- paste0("<", expectRes[paste0("$P",5:11, "N")], ">")
212 214
       expect_equal(thisRes, expectRes)
213
-      
214 215
       expect_equal(keyword(gh, 'P11DISPLAY'), "LOG")
215 216
       
216
-      expect_equal(keyword(gh, '$P8N'), "V450-A")
217
+      expect_equal(keyword(gh, '$P8N'), "<V450-A>")
217 218
     })
218 219
 
219 220
 test_that("getParent",{
... ...
@@ -318,7 +318,12 @@ test_that("keyword",{
318 318
             thisResult[["ORIGINALGUID"]] <-thisResult[["GUID"]] <- basename(thisResult[["FILENAME"]])
319 319
             #skip flowCore_R keys due to the historical archived results do not have this info up to date
320 320
             ind <- !grepl("(flowCore_\\$P)|(transformation)",names(thisResult))
321
-            thisResult[ind]
321
+            thisResult <- thisResult[ind]
322
+            
323
+            #fix legacy result
324
+            if(!islegacyArchivedGS)
325
+              thisResult[paste0("$P",5:11, "N")] <- paste0("<", thisResult[paste0("$P",5:11, "N")], ">")
326
+            thisResult
322 327
           })
323 328
       thisRes <- lapply(thisRes, function(thisResult){
324 329
             thisResult[["FILENAME"]] <- basename(thisResult[["FILENAME"]])
... ...
@@ -326,7 +331,6 @@ test_that("keyword",{
326 331
             ind <- !grepl("(flowCore_\\$P)|(transformation)",names(thisResult))
327 332
             thisResult[ind]
328 333
           })
329
-       
330 334
       expect_equal(thisRes,expectRes)
331 335
       
332 336
       thisRes <- keyword(gs, "$P1N")
... ...
@@ -2,7 +2,6 @@ context("GatingSet archive")
2 2
 
3 3
 gs <- NULL
4 4
 isCpStaticGate <<- TRUE
5
-
6 5
 test_that("load GatingSet from archive",
7 6
 {
8 7
   suppressWarnings(suppressMessages(gs <<- load_gs(list.files(dataDir, pattern = "gs_manual",full = TRUE))))
... ...
@@ -100,6 +99,7 @@ test_that("formatAxis",{
100 99
       
101 100
     })
102 101
 
102
+islegacyArchivedGS <<- TRUE
103 103
 
104 104
 source("GatingSetList-testSuite.R", local = TRUE)
105 105
 
... ...
@@ -134,6 +134,7 @@ test_that("Construct new GatingSet based on the existing gating hierarchy",
134 134
      expect_that(gs, is_a("GatingSet"))
135 135
    })
136 136
 isCpStaticGate <<- TRUE
137
+islegacyArchivedGS <<- FALSE
137 138
 source("GatingSet-testSuite.R", local = TRUE)
138 139
 
139 140
 gh <- NULL
... ...
@@ -137,6 +137,7 @@ test_that("getTransformations ",{
137 137
       
138 138
     })
139 139
 isCpStaticGate <<- TRUE
140
+islegacyArchivedGS <<- FALSE
140 141
 source("GatingHierarchy-testSuite.R", local = TRUE)
141 142
 source("GatingSet-testSuite.R", local = TRUE)
142 143