Browse code

git-svn-id: file:///home/git/hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/crlmm@39329 bc3139a8-67e5-0310-9ffc-ced21a209358

unknown authored on 07/05/2009 00:11:16
Showing 3 changed files

... ...
@@ -151,3 +151,7 @@ is decoded and scanned
151 151
 2009-04-27 R Scharpf - committed version 1.3.1
152 152
 
153 153
 * Fixed bug in nonpolymorphic() function
154
+
155
+2009-05-07 Matt Ritchie - committed version 1.3.2
156
+
157
+* Updated usage of sampleNames() on NChannelSet objects in Illumina functions to maintain consistency with Biobase
... ...
@@ -1,7 +1,7 @@
1 1
 Package: crlmm
2 2
 Type: Package
3 3
 Title: Genotype Calling (CRLMM) and Copy Number Analysis tool for Affymetrix SNP 5.0 and 6.0 and Illumina arrays.
4
-Version: 1.3.1
4
+Version: 1.3.2
5 5
 Date: 2008-12-30
6 6
 Author: Rafael A Irizarry, Benilton S Carvalho <bcarvalh@jhsph.edu>, Robert Scharpf <rscharpf@jhsph.edu>, Matt Ritchie <mritchie@wehi.EDU.AU>
7 7
 Maintainer: Benilton S Carvalho <bcarvalh@jhsph.edu>, Robert Scharpf <rscharpf@jhsph.edu>, Matt Ritchie <mritchie@wehi.EDU.AU>
... ...
@@ -457,7 +457,7 @@ RGtoXY = function(RG, chipType, verbose=TRUE) {
457 457
 #  brgrg = bids[rrgg]
458 458
   X = Y = Xnb = Ynb = Xse = Yse = zero = matrix(0, nsnps, narrays)
459 459
   rownames(X) = rownames(Y) = rownames(Xnb) = rownames(Ynb) = rownames(Xse) = rownames(Yse) = ids
460
-  colnames(X) = colnames(Y) = colnames(Xnb) = colnames(Ynb) = colnames(Xse) = colnames(Yse) = sampleNames(RG)$G
460
+  colnames(X) = colnames(Y) = colnames(Xnb) = colnames(Ynb) = colnames(Xse) = colnames(Yse) = sampleNames(RG) #$G
461 461
 
462 462
   # First sort out Infinium II SNPs, X -> R (allele A)  and Y -> G (allele B) from the same probe
463 463
   X[!is.na(aord),] = exprs(channel(RG, "R"))[aord[!is.na(aord)],] # mostly red
... ...
@@ -529,7 +529,7 @@ stripNormalize = function(XY, useTarget=TRUE, verbose=TRUE) {
529 529
     targetdist = getVarInEnv("reference")
530 530
   
531 531
   Xqws = Yqws = matrix(0, nrow(XY), ncol(XY))
532
-  colnames(Xqws) = colnames(Yqws) = sampleNames(XY)$X
532
+  colnames(Xqws) = colnames(Yqws) = sampleNames(XY) #$X
533 533
   rownames(Xqws) = rownames(Yqws) = featureNames(XY)
534 534
 
535 535
   if(verbose){
... ...
@@ -574,7 +574,7 @@ preprocessInfinium2 = function(XY, mixtureSampleSize=10^5, fitMixture=TRUE, eps=
574 574
     XY = stripNormalize(XY, useTarget=useTarget, verbose=verbose)
575 575
 
576 576
 ## MR: the code below is mostly straight from snprma.R
577
-  if (missing(sns)) sns <- sampleNames(XY)$X
577
+  if (missing(sns)) sns <- sampleNames(XY) #$X
578 578
   if(missing(cdfName))
579 579
     cdfName <- annotation(XY)
580 580
 ##  stuffDir <- changeToCrlmmAnnotationName(cdfName)
... ...
@@ -707,7 +707,7 @@ crlmmIllumina <- function(RG, XY, stripNorm=TRUE, useTarget=TRUE,
707 707
       else
708 708
         stop("Both RG and XY specified - please use one or the other")
709 709
     }
710
-    if (missing(sns)) sns <- sampleNames(XY)$X
710
+    if (missing(sns)) sns <- sampleNames(XY) #$X
711 711
     
712 712
     res = preprocessInfinium2(XY, mixtureSampleSize=mixtureSampleSize, fitMixture=TRUE, verbose=verbose,
713 713
                         seed=seed, eps=eps, cdfName=cdfName, sns=sns, stripNorm=stripNorm, useTarget=useTarget,