Browse code

git-svn-id: file:///home/git/hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/crlmm@48398 bc3139a8-67e5-0310-9ffc-ced21a209358

unknown authored on 25/07/2010 04:42:43
Showing 3 changed files

... ...
@@ -533,3 +533,6 @@ function (which expects ff objects and supports parallel processing)
533 533
 
534 534
 2010-05-26 R. Scharpf committed version 1.7.5
535 535
 ** minor edits to inst/scripts/copynumber.Rnw
536
+
537
+2010-07-25 M. Ritchie committed version 1.7.6
538
+** fixed bug introduced in 1.7.4 by addition of tryCatch() into readIdatFiles().  Thanks to Nolwenn Le Meur for pointing this out.
... ...
@@ -1,8 +1,8 @@
1 1
 Package: crlmm
2 2
 Type: Package
3 3
 Title: Genotype Calling (CRLMM) and Copy Number Analysis tool for Affymetrix SNP 5.0 and 6.0 and Illumina arrays.
4
-Version: 1.7.5
5
-Date: 2010-05-25
4
+Version: 1.7.6
5
+Date: 2010-07-25
6 6
 Author: Rafael A Irizarry, Benilton S Carvalho <carvalho@bclab.org>, Robert Scharpf <rscharpf@jhsph.edu>, Matt Ritchie <mritchie@wehi.edu.au>
7 7
 Maintainer: Benilton S Carvalho <carvalho@bclab.org>, Robert Scharpf <rscharpf@jhsph.edu>, Matt Ritchie <mritchie@wehi.EDU.AU>
8 8
 Description: Faster implementation of CRLMM specific to SNP 5.0 and 6.0 arrays, as well as a copy number tool specific to 5.0, 6.0, and Illumina platforms
... ...
@@ -87,8 +87,11 @@ readIdatFiles <- function(sampleSheet=NULL,
87 87
 	       cat("reading", arrayNames[i], "\t")
88 88
 	       idsG = idsR = G = R = NULL
89 89
 	       cat(paste(sep, fileExt$green, sep=""), "\t")
90
-	       err <- tryCatch(G = readIDAT(grnidats[i]), error=function(e) NULL)
91
-	       if(is.null(err)) next()
90
+	       G <- tryCatch(readIDAT(grnidats[i]), error=function(e) NULL)
91
+	       if(is.null(G)) { 
92
+		       if(i==1) stop("Read in of first IDAT file failed - check your data")
93
+     		   else cat("\n"); next()
94
+		   }
92 95
 	       idsG = rownames(G$Quants)
93 96
 	       headerInfo$nProbes[i] = G$nSNPsRead
94 97
 	       headerInfo$Barcode[i] = G$Barcode
... ...
@@ -263,7 +266,10 @@ readIdatFiles2 <- function(sampleSheet=NULL,
263 266
 	       idsG = idsR = G = R = NULL
264 267
 	       cat(paste(sep, fileExt$green, sep=""), "\t")
265 268
 	       G <- tryCatch(readIDAT(grnidats[i]), error=function(e) NULL)
266
-	       if(is.null(G)) { cat("\n"); next() }
269
+	       if(is.null(G)) { 
270
+		       if(i==1) stop("Read in of first IDAT file failed - check your data")
271
+     		   else cat("\n"); next()
272
+		   }
267 273
 	       idsG = rownames(G$Quants)
268 274
 	       headerInfo$nProbes[i] = G$nSNPsRead
269 275
 	       headerInfo$Barcode[i] = G$Barcode