Browse code

Finishing up adding background batch param

Yuan authored on 13/01/2022 19:03:11
Showing 1 changed files

... ...
@@ -170,7 +170,8 @@ setMethod("decontX", "SingleCellExperiment", function(x,
170 170
     # Remove cells with the same ID between x and the background matrix
171 171
     background <- .checkBackground(x = x, background = background,
172 172
                                    logfile = logfile, verbose = verbose)
173
-    # Does bgBatch needs to be checked?
173
+    
174
+    # TODO: Does bgBatch needs to be checked?
174 175
     
175 176
     if (is.null(bgAssayName)) {
176 177
       bgAssayName <- assayName
... ...
@@ -255,6 +256,9 @@ setMethod("decontX", "ANY", function(x,
255 256
     # Remove cells with the same ID between x and the background matrix
256 257
     background <- .checkBackground(x = x, background = background,
257 258
                                    logfile = logfile, verbose = verbose)
259
+    
260
+    # TODO: Does bgBatch needs to be checked?
261
+    
258 262
   }
259 263
 
260 264
   .decontX(
... ...
@@ -407,9 +411,9 @@ setMethod(
407 411
   if (is.null(batch)) {
408 412
     batch <- rep("all_cells", nC)
409 413
     
410
-    # When no batch, batchBackground can have max 1 batch, depending on if
411
-    # countsBackground supplied
412
-    batchBackground <- rep("all_cells", ncol(countsBackground))
414
+    if (!is.null(countsBackground)) {
415
+      batchBackground <- rep("all_cells", ncol(countsBackground))
416
+    }
413 417
   }
414 418
   runParams$batch <- batch
415 419
   batchIndex <- unique(batch)