Browse code

Commit made by the Bioconductor Git-SVN bridge. Consists of 1 commit.

Commit information:

Commit id: 64613833bc6c16668d484639dc935ea5d721ec28

fixed various small issues like man pages, CITATION etc.

Committed by: Kasper Daniel Hansen
Author Name: Kasper Daniel Hansen
Commit date: 2014-09-21 12:44:59 -0400
Author date: 2014-09-21 12:44:59 -0400


git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/bsseq@94342 bc3139a8-67e5-0310-9ffc-ced21a209358

khansen authored on 21/09/2014 16:45:10
Showing 5 changed files

... ...
@@ -1,5 +1,5 @@
1 1
 Package: bsseq
2
-Version: 1.1.1
2
+Version: 1.1.2
3 3
 Title: Analyze, manage and store bisulfite sequencing data
4 4
 Description: Tools for analyzing and visualizing bisulfite sequencing data
5 5
 Authors@R: c(person(c("Kasper", "Daniel"), "Hansen", role = c("aut", "cre"),
... ...
@@ -7,6 +7,8 @@ setValidity("BSseq", function(object) {
7 7
     if(class(rowData(object)) != "GRanges")
8 8
         msg <- validMsg(msg, sprintf("object of class '%s' needs to have a 'GRanges' in slot 'rowData'", class(object)))
9 9
     ## benchmarking shows that min(assay()) < 0 is faster than any(assay() < 0) if it is false
10
+    if(is.null(colnames(object)))
11
+        msg <- validMsg(msg, "colnames (aka sampleNames) need to be set")
10 12
     if(min(assay(object, "M")) < 0)
11 13
         msg <- validMsg(msg, "the 'M' assay has negative entries")
12 14
     if(min(assay(object, "Cov")) < 0)
... ...
@@ -1,16 +1,13 @@
1 1
 bibentry("Article",
2 2
          title = "{BSmooth: from whole genome bisulfite sequencing reads to differentially methylated regions}",
3
-         author = personList(
4
-         person(c("Kasper", "D."), "Hansen"),
5
-         person("Benjamin", "Langmead"),
6
-         person(c("Rafael", "A."), "Irizarry")),
3
+         author = "Hansen, Kasper D. and Langmead, Benjamin and Irizarry, Rafael A.",
7 4
          journal = "Genome Biology",
8
-         year = 2012,
5
+         year = "2012",
9 6
 	 volume = "13",
10 7
 	 pages = "R83",
11 8
   	 textVersion = 
12
-         paste("KD Hansen, B Langmead, and RA Irizarry.",
9
+         paste("KD Hansen, B Langmead and RA Irizarry.",
13 10
                "BSmooth: from whole genome bisulfite sequencing reads to differentially methylated regions.", 
14
-"Genome Biology, 13:R83 (2012)")
11
+               "Genome Biology, 13:R83 (2012)")
15 12
 )
16 13
 
... ...
@@ -21,6 +21,11 @@
21 21
     This bug fix does not change the output of the function under any
22 22
     input, it only makes it faster.  Reported by Julien Roux
23 23
     <jroux@uchicago.edu>.
24
+    \item validity now checks for the presence of colnames (sampleNames)
25
+    which was assumed to be set.  Reported by Kevin Rue-Albrecht
26
+    <kevin.rue@ucdconnect.ie>.
27
+    \item Fixed a man page issue.
28
+    \item SLightly changed CITATION.
24 29
   }
25 30
 }
26 31
 
... ...
@@ -18,6 +18,7 @@
18 18
 \alias{start<-,hasGRanges-method}
19 19
 \alias{strand,hasGRanges-method}
20 20
 \alias{strand<-,hasGRanges-method}
21
+\alias{strand<-,hasGRanges,ANY-method}
21 22
 \alias{subsetByOverlaps,GenomicRanges,hasGRanges-method}
22 23
 \alias{subsetByOverlaps,hasGRanges,GenomicRanges-method}
23 24
 \alias{subsetByOverlaps,hasGRanges,hasGRanges-method}