Browse code

Update TODOs

Peter Hickey authored on 20/06/2018 16:20:05
Showing 2 changed files

... ...
@@ -301,6 +301,10 @@ setMethod("findOverlaps", c("FWGRanges", "FWGRanges"), .findOverlaps_FWGRanges)
301 301
                                                BPPARAM) {
302 302
     subverbose <- max(as.integer(verbose) - 1L, 0L)
303 303
 
304
+    # TODO: Instead of using the 'largest' file, use the largest
305
+    #       'cytosine report' file, which will have all loci in the
306
+    #       reference genome; provided all samples were aligned to the same
307
+    #       reference genome, this means it contains all loci.
304 308
     # TODO: Initialise using the 'largest' file (i.e. largest number of lines)?
305 309
     #       Would like to do this without reading the data into memory.
306 310
     #       Some benchmarks can be found at
... ...
@@ -577,7 +577,7 @@ read.bismark <- function(files,
577 577
 # TODO: (long term) Current implementation requires that user can load at least
578 578
 #       one sample's worth of data into memory per worker. Could instead read
579 579
 #       chunks of data, write to sink, load next chunk, etc.
580
-# TODO: Document that if 'gr' is NULL and any 'files' (especially the first
580
+# TODO: Document that if 'loci' is NULL and any 'files' (especially the first
581 581
 #       file) are .cov files, then any loci present in the .cov files will have
582 582
 #       their strand set to *. If you are mixing and matching .cov and
583 583
 #       .cytosineReport files and don't want this behaviour (i.e. you want to