Browse code

3.1.1: XOR, AND, OR: plots of DAGs honor all possible values

ramon diaz-uriarte (at Phelsuma) authored on 06/10/2021 18:38:06
Showing 7 changed files

... ...
@@ -1,8 +1,8 @@
1 1
 Package: OncoSimulR
2 2
 Type: Package
3 3
 Title: Forward Genetic Simulation of Cancer Progression with Epistasis 
4
-Version: 3.1.0
5
-Date: 2021-05-04
4
+Version: 3.1.1
5
+Date: 2021-10-06
6 6
 Authors@R: c(
7 7
 	      person("Ramon", "Diaz-Uriarte", role = c("aut", "cre"),	
8 8
  	   		     email = "rdiaz02@gmail.com"),
... ...
@@ -230,6 +230,9 @@ fast_peaks <- function(x, th) {
230 230
                           th)]))
231 231
 }
232 232
 
233
+## FIXME! Unclear if we need the complete fitness matrix or if it will work with
234
+## pieces (say, after removing those with fitness < WT, to try to make it faster
235
+## and for general use in other cases)
233 236
 
234 237
 ## wrapper to the C++ code
235 238
 wrap_accessibleGenotypes <- function(x, th) {
... ...
@@ -1511,8 +1511,15 @@ fitnessEffectsToIgraph <- function(rT, epistasis, orderEffects) {
1511 1511
     g1 <- graph.data.frame(df)
1512 1512
 
1513 1513
     E(g1)$color <- "black"
1514
+
1514 1515
     E(g1)$color[E(g1)$typeDep == "SM"] <- "blue"
1516
+    E(g1)$color[E(g1)$typeDep == "OR"] <- "blue"
1517
+    E(g1)$color[E(g1)$typeDep == "semimonotone"] <- "blue"    
1518
+    
1515 1519
     E(g1)$color[E(g1)$typeDep == "XMPN"] <- "red"
1520
+    E(g1)$color[E(g1)$typeDep == "XOR"] <- "red"
1521
+    E(g1)$color[E(g1)$typeDep == "xmpn"] <- "red"        
1522
+    
1516 1523
     E(g1)$color[E(g1)$typeDep == "epistasis"] <- "orange"
1517 1524
     E(g1)$color[E(g1)$typeDep == "orderEffect"] <- "orange"
1518 1525
     E(g1)$lty <- 1
... ...
@@ -1,3 +1,7 @@
1
+Changes in version 3.1.1 (2021-10-06):
2
+	- XOR, AND, OR dependencies: plots of DAGs honor all possible values.
3
+	- Few miscell minor changes.
4
+
1 5
 Changes in version 3.0 (for BioC 3.13):
2 6
 	- MAJOR change: frequency dependent fitness available.
3 7
 	- Removed v.1 functionality.
... ...
@@ -151,13 +151,26 @@ test_that("simple correct poset -> graph, 5 nodes, no root", {
151 151
 
152 152
 test_that("to rT from poset, through adjmat with and w.o. root",
153 153
           {
154
-              expect_equal(
154
+              ## Now, this fails with
155
+              ## Error in `name %in% base || grepl("^%.*%$", name)`: 'length(x) = 3 > 1' in coercion to 'logical(1)'
156
+              ## But all.equal does not break. So me thinks this is a problem in expect_equal
157
+              ## and the new expect_waldo_equal.
158
+              ## So I'll use all.equal.
159
+              ## expect_equal(
160
+              ##     OncoSimulR:::adjmat.to.restrictTable(
161
+              ##         OncoSimulR:::posetToGraph(p5, names = 1:5, addroot = FALSE, type = "adjmat"),
162
+              ##         root = FALSE),
163
+              ##     OncoSimulR:::adjmat.to.restrictTable(
164
+              ##         OncoSimulR:::posetToGraph(p5, names = 0:5, addroot = TRUE, type = "adjmat"),
165
+              ##         root = TRUE))
166
+              expect_true(all.equal(
155 167
                   OncoSimulR:::adjmat.to.restrictTable(
156 168
                       OncoSimulR:::posetToGraph(p5, names = 1:5, addroot = FALSE, type = "adjmat"),
157 169
                       root = FALSE),
158 170
                   OncoSimulR:::adjmat.to.restrictTable(
159 171
                       OncoSimulR:::posetToGraph(p5, names = 0:5, addroot = TRUE, type = "adjmat"),
160
-                      root = TRUE))
172
+                      root = TRUE)
173
+              ))
161 174
           })
162 175
 
163 176
 
... ...
@@ -7695,7 +7695,7 @@ small number of children via mutation to non-viable
7695 7695
 "hybrids". Factor this into your equations for death rate, but this
7696 7696
 should be negligible if death rate $\gg$ mutation rate. (You can
7697 7697
 ameliorate this problem slightly by making mutation to the "species
7698
-indicator" locus very small, say $10^{10}$ ---do not set it to 0, as
7698
+indicator" locus very small, say $10^{-10}$ ---do not set it to 0, as
7699 7699
 you will get an error).
7700 7700
 
7701 7701
 Of course, you can extend the scheme above to arbitrary numbers of
... ...
@@ -1,15 +1,15 @@
1 1
 \usepackage[%
2
-		shash={bb4ad3b},
3
-		lhash={bb4ad3b194b97eba03a197a4e6d432f1a1e9167f},
2
+		shash={f4285fb},
3
+		lhash={f4285fb0479557c3f4d2b2f362703a464045bd2c},
4 4
 		authname={ramon diaz-uriarte (at Phelsuma)},
5 5
 		authemail={rdiaz02@gmail.com},
6
-		authsdate={2021-04-27},
7
-		authidate={2021-04-27 15:43:25 +0200},
8
-		authudate={1619531005},
6
+		authsdate={2021-09-01},
7
+		authidate={2021-09-01 14:34:09 +0200},
8
+		authudate={1630499649},
9 9
 		commname={ramon diaz-uriarte (at Phelsuma)},
10 10
 		commemail={rdiaz02@gmail.com},
11
-		commsdate={2021-04-27},
12
-		commidate={2021-04-27 15:43:25 +0200},
13
-		commudate={1619531005},
14
-		refnames={ (HEAD -> freq-dep-fitness, origin/rfitness_scale_3, rfitness_scale_3)}
11
+		commsdate={2021-09-01},
12
+		commidate={2021-09-01 14:34:09 +0200},
13
+		commudate={1630499649},
14
+		refnames={ (HEAD -> freq-dep-fitness, origin/freq-dep-fitness)}
15 15
 	]{gitsetinfo}
16 16
\ No newline at end of file