Browse code

[FIX] Fixes for issues with BiocParallel on Windows - bump to 1.5.1

Giulia Pais authored on 28/10/2021 09:46:19
Showing 7 changed files

... ...
@@ -1,6 +1,6 @@
1 1
 Package: ISAnalytics
2 2
 Title: Analyze gene therapy vector insertion sites data identified from genomics next generation sequencing reads for clonal tracking studies
3
-Version: 1.5.0
3
+Version: 1.5.1
4 4
 Date: 2020-07-03
5 5
 Authors@R: c(
6 6
   person(given = "Andrea",
... ...
@@ -2,6 +2,12 @@
2 2
 title: "NEWS"
3 3
 output: github_document
4 4
 ---
5
+# ISAnalytics 1.5.1 (2021-10-28)
6
+
7
+## FIXES
8
+
9
+* Attempt to fix issues with parallel computation on Windows for some plotting functions
10
+
5 11
 # ISAnalytics 1.3.9 (2021-10-25)
6 12
 
7 13
 ## FIXES
... ...
@@ -1,6 +1,13 @@
1 1
 NEWS
2 2
 ================
3 3
 
4
+# ISAnalytics 1.5.1 (2021-10-28)
5
+
6
+## FIXES
7
+
8
+-   Attempt to fix issues with parallel computation on Windows for some
9
+    plotting functions
10
+
4 11
 # ISAnalytics 1.3.9 (2021-10-25)
5 12
 
6 13
 ## FIXES
... ...
@@ -222,7 +229,7 @@ NEWS
222 229
 
223 230
 ## FIXES
224 231
 
225
--   Fixed minor issues in import\_association\_file when checking
232
+-   Fixed minor issues in import_association_file when checking
226 233
     parameters
227 234
 
228 235
 # ISAnalytics 1.1.6 (2020-02-06)
... ...
@@ -230,25 +237,24 @@ NEWS
230 237
 ## UPGRADES
231 238
 
232 239
 -   It is now possible to save html reports to file from
233
-    import\_parallel\_Vispa2Matrices\_auto and
234
-    import\_parallel\_Vispa2Matrices\_interactive, remove\_collisions
235
-    and compute\_near\_integrations
240
+    import_parallel_Vispa2Matrices_auto and
241
+    import_parallel_Vispa2Matrices_interactive, remove_collisions and
242
+    compute_near_integrations
236 243
 
237 244
 ## FIXES
238 245
 
239
--   Fixed sample\_statistics: now functions that have data frame output
246
+-   Fixed sample_statistics: now functions that have data frame output
240 247
     do not produce nested tables. Flat tables are ready to be saved to
241 248
     file or can be nested.
242
--   Simplified association file check logic in remove\_collisions: now
249
+-   Simplified association file check logic in remove_collisions: now
243 250
     function blocks only if the af doesn’t contain the needed columns
244 251
 
245 252
 # ISAnalytics 1.1.5 (2020-02-03)
246 253
 
247 254
 ## UPGRADES
248 255
 
249
--   Upgraded import\_association\_file function: now file alignment is
250
-    not mandatory anymore and it is possible to save the html report to
251
-    file
256
+-   Upgraded import_association_file function: now file alignment is not
257
+    mandatory anymore and it is possible to save the html report to file
252 258
 -   Updated vignettes and documentation
253 259
 
254 260
 # ISAnalytics 1.1.4 (2020-11-16)
... ...
@@ -288,7 +294,7 @@ NEWS
288 294
     environments that do not have access to a browser)
289 295
 -   Other minor fixes (typos)
290 296
 -   Bug fixes: fixed a few bugs in importing and recalibration functions
291
--   Minor fix in import\_association\_file file function: added multiple
297
+-   Minor fix in import_association_file file function: added multiple
292 298
     strings to be translated as NA
293 299
 
294 300
 ## IMPORTANT NOTES
... ...
@@ -370,7 +376,7 @@ ISanalytics is officially on bioconductor!
370 376
 -   Added functionality: aggregate functions
371 377
 -   Added vignette on aggregate functions
372 378
 -   Added recalibration functions
373
--   Added first analysis function (compute\_abundance)
379
+-   Added first analysis function (compute_abundance)
374 380
 
375 381
 ## SIGNIFICANT USER-VISIBLE CHANGES
376 382
 
... ...
@@ -514,19 +514,11 @@ integration_alluvial_plot <- function(x,
514 514
         purrr::set_names(group_names)
515 515
 
516 516
     # Compute plots in parallel
517
-    p <- if (.Platform$OS.type == "windows") {
518
-        BiocParallel::SnowParam(
519
-            stop.on.error = FALSE,
520
-            progressbar = TRUE,
521
-            tasks = length(groups_to_plot),
522
-            exportglobals = TRUE
523
-        )
524
-    } else {
525
-        BiocParallel::MulticoreParam(
517
+    p <- BiocParallel::MulticoreParam(
526 518
             stop.on.error = FALSE, progressbar = TRUE,
527 519
             tasks = length(groups_to_plot), exportglobals = FALSE
528 520
         )
529
-    }
521
+
530 522
 
531 523
     FUN <- function(group_df,
532 524
     plot_x,
... ...
@@ -88,7 +88,7 @@ if (!require(devtools)) {
88 88
   install.packages("devtools")
89 89
 }
90 90
 devtools::install_github("calabrialab/ISAnalytics",
91
-                         ref = "RELEASE_3_13",
91
+                         ref = "RELEASE_3_14",
92 92
                          dependencies = TRUE,
93 93
                          build_vignettes = TRUE)
94 94
 ```
... ...
@@ -137,6 +137,13 @@ options("ISAnalytics.reports" = TRUE)
137 137
 Show more
138 138
 </summary>
139 139
 
140
+# ISAnalytics 1.5.1 (2021-10-28)
141
+
142
+## FIXES
143
+
144
+-   Attempt to fix issues with parallel computation on Windows for some
145
+    plotting functions
146
+
140 147
 # ISAnalytics 1.3.9 (2021-10-25)
141 148
 
142 149
 ## FIXES
... ...
@@ -358,7 +365,7 @@ Show more
358 365
 
359 366
 ## FIXES
360 367
 
361
--   Fixed minor issues in import\_association\_file when checking
368
+-   Fixed minor issues in import_association_file when checking
362 369
     parameters
363 370
 
364 371
 # ISAnalytics 1.1.6 (2020-02-06)
... ...
@@ -366,25 +373,24 @@ Show more
366 373
 ## UPGRADES
367 374
 
368 375
 -   It is now possible to save html reports to file from
369
-    import\_parallel\_Vispa2Matrices\_auto and
370
-    import\_parallel\_Vispa2Matrices\_interactive, remove\_collisions
371
-    and compute\_near\_integrations
376
+    import_parallel_Vispa2Matrices_auto and
377
+    import_parallel_Vispa2Matrices_interactive, remove_collisions and
378
+    compute_near_integrations
372 379
 
373 380
 ## FIXES
374 381
 
375
--   Fixed sample\_statistics: now functions that have data frame output
382
+-   Fixed sample_statistics: now functions that have data frame output
376 383
     do not produce nested tables. Flat tables are ready to be saved to
377 384
     file or can be nested.
378
--   Simplified association file check logic in remove\_collisions: now
385
+-   Simplified association file check logic in remove_collisions: now
379 386
     function blocks only if the af doesn’t contain the needed columns
380 387
 
381 388
 # ISAnalytics 1.1.5 (2020-02-03)
382 389
 
383 390
 ## UPGRADES
384 391
 
385
--   Upgraded import\_association\_file function: now file alignment is
386
-    not mandatory anymore and it is possible to save the html report to
387
-    file
392
+-   Upgraded import_association_file function: now file alignment is not
393
+    mandatory anymore and it is possible to save the html report to file
388 394
 -   Updated vignettes and documentation
389 395
 
390 396
 # ISAnalytics 1.1.4 (2020-11-16)
... ...
@@ -424,7 +430,7 @@ Show more
424 430
     environments that do not have access to a browser)
425 431
 -   Other minor fixes (typos)
426 432
 -   Bug fixes: fixed a few bugs in importing and recalibration functions
427
--   Minor fix in import\_association\_file file function: added multiple
433
+-   Minor fix in import_association_file file function: added multiple
428 434
     strings to be translated as NA
429 435
 
430 436
 ## IMPORTANT NOTES
... ...
@@ -506,7 +512,7 @@ ISanalytics is officially on bioconductor!
506 512
 -   Added functionality: aggregate functions
507 513
 -   Added vignette on aggregate functions
508 514
 -   Added recalibration functions
509
--   Added first analysis function (compute\_abundance)
515
+-   Added first analysis function (compute_abundance)
510 516
 
511 517
 ## SIGNIFICANT USER-VISIBLE CHANGES
512 518
 
... ...
@@ -58,15 +58,11 @@ reference:
58 58
 - contents:
59 59
   - aggregate_metadata
60 60
   - aggregate_values_by_key
61
-- title: "Collision removal functions"
61
+- title: "Data cleaning and pre-processing"
62 62
 - contents:
63
+  - compute_near_integrations
63 64
   - remove_collisions
64 65
   - realign_after_collisions
65
-- title: "Recalibration functions"
66
-- contents:
67
-  - compute_near_integrations
68
-- title: "Removal of outliers from raw reads"
69
-- contents:
70 66
   - outlier_filter
71 67
   - outliers_by_pool_fragments
72 68
 - title: "Analysis functions"
... ...
@@ -132,4 +128,3 @@ reference:
132 128
   - refGenes_hg19
133 129
   - refGenes_mm9
134 130
   - tumor_suppressors
135
-
... ...
@@ -47,7 +47,7 @@ if (!require(devtools)) {
47 47
   install.packages("devtools")
48 48
 }
49 49
 devtools::install_github("calabrialab/ISAnalytics",
50
-                         ref = "RELEASE_3_13",
50
+                         ref = "RELEASE_3_14",
51 51
                          dependencies = TRUE,
52 52
                          build_vignettes = TRUE)
53 53
 ```