@@ -2,6 +2,7 @@ CHANGES in VERSION 2.3.1

 * `anno_points()`: allows images as symbols.

 * add `HEATMAP_LEGEND_PADDING` and `ANNOTATION_LEGEND_PADDING` options in `ht_opt`

+* `oncoPrint()`: print messages if there are NA values in the input matrix

 ========================

@@ -239,7 +239,7 @@ densityHeatmap = function(data,

 				labels = labels[od]

 				pushViewport(viewport(xscale = c(0.5, n + 0.5), yscale = c(min_x, max_x), clip = FALSE))

-				text_height = convertHeight(grobHeight(textGrob(labels[1])) * 1.5, "native", valueOnly = TRUE)

+				text_height = convertHeight(grobHeight(textGrob(labels[1])) * 2, "native", valueOnly = TRUE)

 		        h1 = y - text_height*0.5

 		        h2 = y + text_height*0.5

 		        pos = rev(smartAlign(h1, h2, c(min_x, max_x)))

@@ -128,6 +128,11 @@ oncoPrint = function(mat,

 		all_type = all_type[!is.na(all_type)]

 		all_type = all_type[grepl("\\S", all_type)]

+		## check whether there are NA values in the matrix

+		if(any(is.na(mat))) {

+			message_wrap("Found NA values in the matrix and treat as no alteration. If `NA` means no alteration, you can explicitly set it to empty strings like ''. If `NA` is an alteration type, you should format it to a string like `'NA'` and define a graphic for it.")

+		}

+

 		mat_list = lapply(all_type, function(type) {

 			m = sapply(mat, function(x) type %in% get_type2(x))

 			dim(m) = dim(mat)